[PATCH] D30206: [DWARF5] Emit new unit header

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFUnit.h:127
   const DWARFAbbreviationDeclarationSet *Abbrevs;
+  uint8_t UnitType;
   uint8_t AddrSize;
----------------
probinson wrote:
> I had noticed the packing here is not optimal, `Version` can move after `Abbrevs` to save a little space.  Not a big deal as there are usually relatively few units, but I thought I'd mention it.  Can be saved for a separate cleanup commit.
Let's do this as a separate NFC commit; no need to do pre-commit review for this change.


================
Comment at: test/DebugInfo/Inputs/dwarfdump-header.s:6
+# llvm-mc -triple x86_64-unknown-linux dwarfdump-header.s -filetype=obj \
+#         -o dwarfdump-header.elf-x86-64
+
----------------
I like the approach of using assembler for this!


https://reviews.llvm.org/D30206