[PATCH] D30335: [LLD] Add terminator to .eh_frame sections

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: tools/lld/ELF/OutputSections.cpp:413
   }
-  this->Size = Off;
+  // Add terminator.
+  this->Size = Off + 4;
----------------
This needs to be a bit more friendly for future software archaeologist. Please also mention that

 - .eh_frame can optionally end with an empty CIE which is a 4 byte zero,
 - adding a terminator is not required by the standard, but
 - we add that for the sake of compatibility with the GNU linker because they always add that (and some tools seem to depend on that).


https://reviews.llvm.org/D30335