[PATCH] D30043: [Polly][Cmake] Optionally use a system isl version.

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 24 05:57:00 PST 2017


Meinersbur added a comment.

One suggestion left: I feel that the name `POLLY_USE_EXTERNAL_ISL` is ambiguous. Could be confused with `LLVM_EXTERNAL_*`. If it is OFF it uses isl from `lib/External/isl`. Could we change it to `POLLY_BUNDLED_ISL` and set it to ON by default? What do you think?

I tried it under Windows as well and it didn't work: no pkg-config available there. `pkg_search_module` also doesn't allow to configure the isl lib/include dirs manually. However, this is no concern atm as I don't know a reason why I would want an external isl on Windows.


https://reviews.llvm.org/D30043





More information about the llvm-commits mailing list