[PATCH] D30329: [AArch64InstPrinter] rewrite of printSysAlias

[Oliver Stannard via Phabricator via llvm-commits]

olista01 added inline comments.


================
Comment at: lib/Target/AArch64/InstPrinter/AArch64InstPrinter.cpp:766
+    case 1: case 5: {
+      // There is no op0, so we do no need to set bit 14
+      const AArch64IC::IC *IC = AArch64IC::lookupICByEncoding(Encoding);
----------------
I think it would be better remove the op0 fields from the other three alias classes, as it is defined to always be 0b01 for all of them.


================
Comment at: lib/Target/AArch64/InstPrinter/AArch64InstPrinter.cpp:820
+  O << '\t' << Str;
+    if (NeedsReg)
+      O << ", " << getRegisterName(MI->getOperand(4).getReg());
----------------
Indentation.


https://reviews.llvm.org/D30329