[PATCH] OptDiag: Summarize the instruction count in asm-printer
Adam Nemet via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 23 17:19:17 PST 2017
> On Feb 23, 2017, at 4:58 PM, Justin Bogner <mail at justinbogner.com> wrote:
>
> Adam Nemet <anemet at apple.com> writes:
>>> On Feb 3, 2017, at 6:11 PM, Justin Bogner <mail at justinbogner.com> wrote:
>>>
>>> Adam Nemet <anemet at apple.com> writes:
>>>> LGTM too but can you please put this behind a command-line flag for
>>>> now? I need to add the capability to MachineORE to use MachineBFI
>>>> lazily. Otherwise we would populate BFI in AsmPrinter now even if
>>>> hotness is not requested.
>>>
>>> I can probably wait for you to get that in to land this if you think
>>> you'll get to it in the next week or so. Duncan pointed out offline that
>>> manufacturing the DebugLoc like this is kind of expensive, so I might
>>> try to rework the DiagnosticInfo stuff to store the line info directly
>>> instead of relying on a DebugLoc before finishing this.
>>
>> Justin,
>>
>> This landed in r295071-r295073.
>>
>> Please let me know when you commit your change so that I can land
>> https://reviews.llvm.org/D29837 on top.
>
> This is committed in r296053. Thanks!
Did you forget committing the test?
More information about the llvm-commits
mailing list