[PATCH] D26872: Outliner: Add MIR-level outlining pass

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 23 17:11:38 PST 2017


> On Feb 23, 2017, at 5:01 PM, Adrian Prantl via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> 
>> On Feb 23, 2017, at 4:18 PM, Matthias Braun via Phabricator <reviews at reviews.llvm.org> wrote:
>> 
>> MatzeB accepted this revision.
>> MatzeB added a comment.
>> This revision is now accepted and ready to land.
>> 
>> Thanks for pushing this, this is coming along nicely!
>> 
>> At this point I don't see any correctness or compiletime problems (with the comments below addressed).
> 
> Just to make sure this doesn't get lost, there *is* a correctness bug with how DBG_VALUEs are handled. (See my comment on line 10412). It would be good to get this fixed before committing.
Yes sorry. I had discussed this with Jessica in person and she was already working on it while I was doing the review, so I did not mark it again in my review.

- Matthias



More information about the llvm-commits mailing list