[PATCH] D30246: [ADT] Fix zip iterator interface.

[Daniel Berlin via Phabricator via llvm-commits]

dberlin accepted this revision.
dberlin added a comment.
This revision is now accepted and ready to land.

If you change it to:
diff --git a/include/llvm/ADT/STLExtras.h b/include/llvm/ADT/STLExtras.h
index 44bf84d1d1e..a1e2b072528 100644

- a/include/llvm/ADT/STLExtras.h

+++ b/include/llvm/ADT/STLExtras.h
@@ -360,7 +360,8 @@ template <typename ZipType, typename... Iters>
 using zip_traits =

  iterator_facade_base<ZipType, std::input_iterator_tag,
                       std::tuple<decltype(*std::declval<Iters>())...>,

- std::ptrdiff_t,

+                         typename std::iterator_traits<typename std::tuple_element<
+                             0, std::tuple<Iters...>>::type>::difference_type,

  std::tuple<decltype(*std::declval<Iters>())...> *,
  std::tuple<decltype(*std::declval<Iters>())...>>;

I think this would be ready to go in :)


Repository:
  rL LLVM

https://reviews.llvm.org/D30246