[PATCH] D30156: llvm-mc-fuzzer: add support for assembly

[Kostya Serebryany via Phabricator via llvm-commits]

kcc accepted this revision.
kcc added a comment.
This revision is now accepted and ready to land.

Looks good. We can iterate after this version is submitted. 
I've left two comments, but feel free to address them in future commits.



================
Comment at: tools/llvm-mc-disassemble-fuzzer/llvm-mc-disassemble-fuzzer.cpp:78
+int LLVMFuzzerTestOneInput(const uint8_t *Data, size_t Size) {
+  if (Size < 1024) { return 0; }
+
----------------
why do you limit the size this way? 
Isn't it useful to run tiny inputs? 


================
Comment at: tools/llvm-mc-disassemble-fuzzer/llvm-mc-disassemble-fuzzer.cpp:96
+  //
+  // Infinitely fuzz the little-endian MIPS64R2 disassembler with the MSA
+  // feature enabled using up to 64-byte inputs:
----------------
what will be the behavior if no flags are supplied? 
Can we set the default values so that the fuzzer will do something meaningful w/o any flags?

Also, if we have the default values as a macro that we can re-define from a cmake flag, 
this will solve the problem of building multiple binaries . 


Repository:
  rL LLVM

https://reviews.llvm.org/D30156