[PATCH] D30258: [ELF] - Implemented --no-dynamic-linker option
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 23 11:24:14 PST 2017
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM with the following changes.
================
Comment at: ELF/Driver.cpp:591
Config->OFormatBinary = isOutputFormatBinary(Args);
Config->SectionStartMap = getSectionStartMap(Args);
----------------
As you can see the code is roughly grouped in this function. Please keep it consistent. Probably you need to move the line here.
================
Comment at: ELF/Options.td:152
+def no_dynamic_linker: F<"no-dynamic-linker">;
+
def no_export_dynamic: F<"no-export-dynamic">;
----------------
Remove this blank line to keep the style consistent.
https://reviews.llvm.org/D30258
More information about the llvm-commits
mailing list