[PATCH] D30303: Convert EhOutputSection to be a synthetic section

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 23 11:19:34 PST 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/Writer.cpp:1095
 
-  if (!Out<ELFT>::EhFrame->empty()) {
-    OutputSections.push_back(Out<ELFT>::EhFrame);
-    Out<ELFT>::EhFrame->finalize();
-  }
+  // This has to be before the relocation scan.
+  finalizeSynthetic<ELFT>({In<ELFT>::EhFrame});
----------------
Can you add why?


https://reviews.llvm.org/D30303





More information about the llvm-commits mailing list