[PATCH] D26872: Outliner: Add MIR-level outlining pass

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/Target/X86/X86InstrInfo.cpp:10412
+  if (MI.isDebugValue())
+    return false;
+
----------------
This is not the right way to do this. We need to skip over DBG_VALUE instruction as if they didn't exist. Otherwise the presence of DBG_VALUEs in the instruction stream will have an effect on the outlining decision, which means that compiling with -g will generate different code than without.

Please also be sure to include a testcase that exercises this.


https://reviews.llvm.org/D26872