[PATCH] D30218: Use base discriminator in sample pgo profile matching.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 23 09:29:54 PST 2017


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

This seems good to me - so long as the tests would fail if the implementation was reverted. (I haven't thought about it hard enough - but it's possible in general that a test could fail with a new implementation, be updated to be compatible with the new implementation - but also be compatible with the old implementation, thus not acting as a regression test against the new implementation/functionality)


https://reviews.llvm.org/D30218





More information about the llvm-commits mailing list