[PATCH] D29897: [BypassSlowDivision] Use ValueTracking to simplify run-time checks

Nikolai Bozhenov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 23 08:57:15 PST 2017


n.bozhenov marked 3 inline comments as done.
n.bozhenov added a comment.

Well, it might make sense to write opt tests here... But we already have got 3 files with 18 llc tests for division bypassing. Moreover, while working on this patchset, the tests were thoroughly reviewed, it was insisted that the test should be written this way, I had to make a number of commits specifically to modify the tests. So, I don't think it would be a good idea to throw away all the work that has been done and re-write the tests from scratch now.


https://reviews.llvm.org/D29897





More information about the llvm-commits mailing list