[polly] r295986 - [DependenceInfo] Use references instead of double pointers. NFC.
Michael Kruse via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 23 07:40:56 PST 2017
Author: meinersbur
Date: Thu Feb 23 09:40:56 2017
New Revision: 295986
URL: http://llvm.org/viewvc/llvm-project?rev=295986&view=rev
Log:
[DependenceInfo] Use references instead of double pointers. NFC.
Non-const references are the more C++-ish way to modify a variable
passed by the caller.
Modified:
polly/trunk/lib/Analysis/DependenceInfo.cpp
Modified: polly/trunk/lib/Analysis/DependenceInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/lib/Analysis/DependenceInfo.cpp?rev=295986&r1=295985&r2=295986&view=diff
==============================================================================
--- polly/trunk/lib/Analysis/DependenceInfo.cpp (original)
+++ polly/trunk/lib/Analysis/DependenceInfo.cpp Thu Feb 23 09:40:56 2017
@@ -111,16 +111,16 @@ static __isl_give isl_map *tag(__isl_tak
}
/// Collect information about the SCoP @p S.
-static void collectInfo(Scop &S, isl_union_map **Read, isl_union_map **Write,
- isl_union_map **MayWrite,
- isl_union_map **ReductionTagMap,
- isl_union_set **TaggedStmtDomain,
+static void collectInfo(Scop &S, isl_union_map *&Read, isl_union_map *&Write,
+ isl_union_map *&MayWrite,
+ isl_union_map *&ReductionTagMap,
+ isl_union_set *&TaggedStmtDomain,
Dependences::AnalysisLevel Level) {
isl_space *Space = S.getParamSpace();
- *Read = isl_union_map_empty(isl_space_copy(Space));
- *Write = isl_union_map_empty(isl_space_copy(Space));
- *MayWrite = isl_union_map_empty(isl_space_copy(Space));
- *ReductionTagMap = isl_union_map_empty(isl_space_copy(Space));
+ Read = isl_union_map_empty(isl_space_copy(Space));
+ Write = isl_union_map_empty(isl_space_copy(Space));
+ MayWrite = isl_union_map_empty(isl_space_copy(Space));
+ ReductionTagMap = isl_union_map_empty(isl_space_copy(Space));
isl_union_map *StmtSchedule = isl_union_map_empty(Space);
SmallPtrSet<const ScopArrayInfo *, 8> ReductionArrays;
@@ -149,8 +149,8 @@ static void collectInfo(Scop &S, isl_uni
// This is used in Dependences::calculateDependences to create
// a tagged Schedule tree.
- *ReductionTagMap =
- isl_union_map_add_map(*ReductionTagMap, isl_map_copy(accdom));
+ ReductionTagMap =
+ isl_union_map_add_map(ReductionTagMap, isl_map_copy(accdom));
accdom = isl_map_range_map(accdom);
} else {
accdom = tag(accdom, MA, Level);
@@ -165,9 +165,9 @@ static void collectInfo(Scop &S, isl_uni
}
if (MA->isRead())
- *Read = isl_union_map_add_map(*Read, accdom);
+ Read = isl_union_map_add_map(Read, accdom);
else
- *Write = isl_union_map_add_map(*Write, accdom);
+ Write = isl_union_map_add_map(Write, accdom);
}
if (!ReductionArrays.empty() && Level == Dependences::AL_Statement)
@@ -176,12 +176,12 @@ static void collectInfo(Scop &S, isl_uni
StmtSchedule =
isl_union_map_intersect_params(StmtSchedule, S.getAssumedContext());
- *TaggedStmtDomain = isl_union_map_domain(StmtSchedule);
+ TaggedStmtDomain = isl_union_map_domain(StmtSchedule);
- *ReductionTagMap = isl_union_map_coalesce(*ReductionTagMap);
- *Read = isl_union_map_coalesce(*Read);
- *Write = isl_union_map_coalesce(*Write);
- *MayWrite = isl_union_map_coalesce(*MayWrite);
+ ReductionTagMap = isl_union_map_coalesce(ReductionTagMap);
+ Read = isl_union_map_coalesce(Read);
+ Write = isl_union_map_coalesce(Write);
+ MayWrite = isl_union_map_coalesce(MayWrite);
}
/// Fix all dimension of @p Zero to 0 and add it to @p user
@@ -304,7 +304,7 @@ void Dependences::calculateDependences(S
DEBUG(dbgs() << "Scop: \n" << S << "\n");
- collectInfo(S, &Read, &Write, &MayWrite, &ReductionTagMap, &TaggedStmtDomain,
+ collectInfo(S, Read, Write, MayWrite, ReductionTagMap, TaggedStmtDomain,
Level);
bool HasReductions = !isl_union_map_is_empty(ReductionTagMap);
More information about the llvm-commits
mailing list