[PATCH] D29388: [PPC] Use rldicr instruction for AND with an immediate if possible

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

Please add a test that intentionally triggers this transformation (i.e. the test case that motivated the patch). It doesn't necessarily have to be in a separate test case - you can just add a function to an existing test case that does this. I don't think this requires another review - you can address these on the commit.



================
Comment at: lib/Target/PowerPC/PPCISelDAGToDAG.cpp:2717
     }
+    // If this is a negated 64-bit zero-extension mask, emit clrrdi (rldicr)
+    if (isInt64Immediate(N->getOperand(1).getNode(), Imm64) &&
----------------
Nit: please always make comments full sentences.


https://reviews.llvm.org/D29388