[PATCH] D30277: [COFF] added test for thinlto

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 22 16:59:41 PST 2017


mehdi_amini added inline comments.


================
Comment at: test/COFF/thinlto.ll:106
+; TEXT-10-NEXT: addq	$40, %rsp
+; TEXT-10-NEXT: retq
+
----------------
inglorion wrote:
> mehdi_amini wrote:
> > Why do we check this exact sequence of assembly? Overall I don't know what this test is enforcing / verifying right now.
> > 
> This was essentially performing the same checks as lto.ll. However, per @pcc's suggestion, I've changed the test to be much simpler and not actually look at the disassembly.
Thanks, looks good!
(and I agree with the idea of using llvm-nm where possible/appropriate)


https://reviews.llvm.org/D30277





More information about the llvm-commits mailing list