[PATCH] D29916: [CGP] Split some critical edges coming out of indirect branches

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 22 14:31:02 PST 2017


efriedma added a comment.

> I can try to craft a test that approximates the performance impact. I'm not sure it would make sense to add python itself to the test suite.

The key is that we need some coverage for this fix; without a test, if indirectbr handling breaks somehow in the future, we won't know until someone complains about a huge performance regression a year later.

Patch looks fine, but I'd like to see perf numbers from the testsuite showing an improvement before we merge this.


https://reviews.llvm.org/D29916





More information about the llvm-commits mailing list