[PATCH] D30115: [RFC] Add MachineInstr::MIFlag parameter to storeRegToStackSlot

[Alex Bradbury via Phabricator via llvm-commits]

asb added a comment.

@nemanjai: MachineInstr::setFlag will do `Flags |= Flag`, so any previously set flags are maintained.

I agree that having a NoFlags default would be better, I mainly left it as required to potentially benefit from more eyes on the storeRegToStackSlot call sites while the patch is in its early stages.

I'm starting to wonder if I'd be better off making it so emitPrologue and emitEpilogue take an iterator pointing to after the callee-saved spill and before the callee-saved restores, particularly as it sounds like it's not particularly important to have these flags on callee saves/restores ([http://lists.llvm.org/pipermail/llvm-dev/2017-February/110398.html](ref)), beyond this task of finding where to set the frame pointer.


https://reviews.llvm.org/D30115