[PATCH] D29512: [PGO] Directory name stripping in global identifier for static functions

[Rong Xu via Phabricator via llvm-commits]

xur added a comment.

In https://reviews.llvm.org/D29512#666652, @mehdi_amini wrote:

> From the description:
>
> > Current internal option -static-func-full-module-prefix strips all the directory path the profile counter names for static functions. The default of this option is true.
>
> ...
>
> > This patch turns the default value for -static-func-full-module-prefix to false.
>
> However in the diff I see:
>
> - "static-func-full-module-prefix", cl::init(false), +    "static-func-full-module-prefix", cl::init(true),
>
>   Which is the opposite of the description? This seems confusing to me.


Sorry for the confusion. It seems my description was not accurate.

The current default value for -static-func-full-module-prefix is false, which means it strips all the path names.

This patch will make the default value as true, which keeps the path names.


https://reviews.llvm.org/D29512