[PATCH] D30221: Move updating functions to MemorySSAUpdater.Add updater to passes that now need it.Move around code in MemorySSA to expose needed functions.

[Piotr Padlewski via llvm-commits]

OK, I was just making sure. LGTM

2017-02-22 18:53 GMT+01:00 Daniel Berlin <dberlin at dberlin.org>:

> Yes, but i don't expect to get to that for a month.
>
>
> On Wed, Feb 22, 2017 at 9:25 AM, Piotr Padlewski via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> Prazek added inline comments.
>>
>>
>> ================
>> Comment at: include/llvm/Transforms/Utils/MemorySSAUpdater.h:90-94
>> +  // The below are utility functions. Other than creation of accesses to
>> pass
>> +  // to insertDef, and removeAccess to remove accesses, you should
>> generally
>> +  // not attempt to update memoryssa yourself. It is very non-trivial to
>> get
>> +  // the edge cases right, and the above calls already operate in
>> near-optimal
>> +  // time bounds.
>> ----------------
>> The plan is to remove these functions in the future right?
>>
>>
>> https://reviews.llvm.org/D30221
>>
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170222/6d04bd8b/attachment.html>