[PATCH] D30242: [ExecutionDepsFix] Don't make copies of LiveReg objects when collecting operands for soft instructions

Marina Yatsina via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 22 07:46:48 PST 2017


myatsina added a comment.

I've seen some places that do SmallVector<std::unique_ptr<type>, size>. This might be a bit better as it states explicitly that there is no duplication in this data structure.

Another option is using SamllSetVector data structure and std::sort (instead of the sorted insertion section), but it will require to define a comparison operator for LiveReg.


https://reviews.llvm.org/D30242





More information about the llvm-commits mailing list