[PATCH] D29777: [Reassociate] Convert shl by constant into multiply during tree linearization.

[Chad Rosier via Phabricator via llvm-commits]

mcrosier added a comment.

In https://reviews.llvm.org/D29777#682749, @chandlerc wrote:

> Some longer term comments here, but all of this seems reasonably in-line with how we currently do things in reassociate, but raises some long-standing issues in a potentially more concerning area.


After thinking a bit and discussing this with Eli, this patch (and https://reviews.llvm.org/D30223) really are just papering over the issue.  See Eli's comments in https://reviews.llvm.org/D30228 for a good description of what's going on; https://reviews.llvm.org/D30228 also directly address the problem.


https://reviews.llvm.org/D29777