[PATCH] D27900: [ELF] - Keep the source file/line location information separate from the object file location information.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/InputSection.h:143
 
-  // Returns a source location string. Used to construct an error message.
-  std::string getLocation(uintX_t Offset);
+  // Returns a detailed information about source location. Used to construct an
+  // error message.
----------------
jhenderson wrote:
> Nit: Not sure if the comment needs to change, but it should start "Returns detailed information", without the "a"
Fixed.


================
Comment at: test/ELF/libsearch.s:25
 // RUN:   | FileCheck --check-prefix=UNDEFINED %s
-// UNDEFINED: error: {{.*}}:(.bar+0x0): undefined symbol '_bar'
+// UNDEFINED: error: {{.*}}: undefined symbol '_bar'
 
----------------
jhenderson wrote:
> Should this have a check for "note: location is (.bar+0x0)" or similar?
Yes, fixed.


================
Comment at: test/ELF/unresolved-symbols.s:24
+# ERRUND:      error: {{.*}}: undefined symbol 'undef'
+# ERRUND-NEXT: f
 ## Also ignore all should not produce error for symbols from DSOs.
----------------
jhenderson wrote:
> This check looks like it could easily start passing spuriously due to other error output, since it is only checking a single character. Could we at least check for "note: {{.*}} f" or equivalent for whatever the text is?
I think "f" here probably was either mistype or a placeholder to trigger testcase fail to get the proper line, which passed by mistake and was forgotten.
Fixed.


https://reviews.llvm.org/D27900