[PATCH] D29983: [LLD][ELF] Calculate sizes of SHF_ALLOC Synthetic Sections early

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 21 14:31:28 PST 2017


ruiu added inline comments.


================
Comment at: ELF/SyntheticSections.h:52
+  // should do as much as possible including finalizing the section size
+  virtual void earlyFinalize() {}
+  // If the size calculation needs to be updated during Thunk creation
----------------
We are probably using the term `finalize` too much in the linker. It used to be that one class, OutputSection, has a finalizer function that fix the output section layout. Now many classes have finalizers functions and they do different things at different stages. That is hard to read. I'd like to remove all uses of `finalize` from the linker.


https://reviews.llvm.org/D29983





More information about the llvm-commits mailing list