[PATCH] D30136: [compiler-rt][builtins][WIP] Add _IsOSVersionAtLeast, to be used by ObjC's @available

Nico Weber via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 21 13:41:30 PST 2017


Why is Gestalt deprecated if it's what you think should be used here?

On Mon, Feb 20, 2017 at 12:19 PM, Alex Lorenz via Phabricator <
reviews at reviews.llvm.org> wrote:

> arphaman added a comment.
>
> Thanks for taking your time to work on this!
>
> We've discussed the best approach internally and came to the conclusion
> that `Gestalt` should be used to determine the version of the OS even
> though it's officially deprecated. I'm sorry if my previous comments in
> which I dismissed `Gestalt` made you do extra work, I wasn't aware of some
> nuances back then. Can you please rewrite this function to use `Gestalt`?
>
>
> https://reviews.llvm.org/D30136
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170221/37d6161f/attachment.html>


More information about the llvm-commits mailing list