[PATCH] D27405: Make sancov.py py3-compatible

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 21 13:35:50 PST 2017


Python 3 support sounds good in general, but I don't see how this is
addressing a regression since 3.9. I don't want to merge them this
late in the release process.

On Mon, Feb 20, 2017 at 6:02 PM, NAKAMURA Takumi via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Hans, could you pull 6 of them below into release_40, please?
> I checked check-asan runs with py3.
>
> [r294306] sancov.py: [Py3] Use '//' instead of '/' as division operator.
> [r294307] sancov.py: [Py3] Use bytes.decode() explicitly.
> [r294812] sancov.py: [Py3] Use sys.stdout.buffer for bytes.
> [r294880] sancov.py: [Py3] Get rid of "print" statement. Use print() or
> write() instead.
>
> [r294303] asan_symbolize.py: [Py3] Use text mode with
> universal_newlines=True for Popen.
> [r294450] asan_symbolize.py: [Py3] Get rid of "print" statement. Use print()
> or write() instead.
>
> On Sun, Feb 12, 2017 at 9:39 AM NAKAMURA Takumi via Phabricator
> <reviews at reviews.llvm.org> wrote:
>>
>> chapuni added a comment.
>>
>> Thanks @aizatsky, check-asan is py3-compatible now.
>>
>>
>> Repository:
>>   rL LLVM
>>
>> https://reviews.llvm.org/D27405
>>
>>
>>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>


More information about the llvm-commits mailing list