[PATCH] D30124: [ARM] Fix insert point for store rescheduling.

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added a comment.

In https://reviews.llvm.org/D30124#682728, @rengolin wrote:

> In https://reviews.llvm.org/D30124#682714, @MatzeB wrote:
>
> > The change itself looks straightforward.
> >  Having the magic number `8` tunable would indeed be nice, unfortunately target features are only boolean (enable or disabled) today; While I would applaud everyone improving the targetfeature system to support arbitrary integer values, I don't think we need to block this bugfix for it esp. since the magic number already existed in the code.
>
>
> We already have integer values attributed to sub-architectures. But I'm not fussed about this in particular, just thought it would be a good and easy place to already fix the fixme.


Ok, true. ARMSubTarget::initSubtargetFeatures() can set arbitrary values depend on the selected architecture, this may actually be useful here. What I wanted to say is that the subtarget feature APIs/tablegen do not allow you to do something like `llc -mattr=MyLimit=8` yet.


Repository:
  rL LLVM

https://reviews.llvm.org/D30124