[PATCH] D30221: Move updating functions to MemorySSAUpdater.Add updater to passes that now need it.Move around code in MemorySSA to expose needed functions.

[George Burgess IV via Phabricator via llvm-commits]

george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.

a few nits, and LGTM. thanks!



================
Comment at: include/llvm/Transforms/Utils/MemorySSA.h:638
 
-  // This is used by the updater to perform the internal memoryssa machinations
-  // for moves.  It does not always leave the IR in a correct state, and relies
-  // on the updater to fixup what it breaks, so it is not public.
+  // These is used by the updater to perform various internal MemorySSA
+  // machinsations.  They do not always leave the IR in a correct state, and
----------------
s/is/are/


================
Comment at: include/llvm/Transforms/Utils/MemorySSA.h:640
+  // machinsations.  They do not always leave the IR in a correct state, and
+  // relies on the updater to fixup what it breaks, so it is not public.
+
----------------
s/relies/rely/


================
Comment at: lib/Transforms/Utils/MemorySSAUpdater.cpp:490
+  MSSA->insertIntoListsBefore(NewAccess, InsertPt->getBlock(),
+                              ++(InsertPt->getIterator()));
+  return NewAccess;
----------------
redundant parens


https://reviews.llvm.org/D30221