[PATCH] D28968: LoopUnswitch - Simplify based on known not to a be constant.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/Transforms/Scalar/LoopUnswitch.cpp:1395
+    Value *Op1 = CI->getOperand(1);
+    if ((Op0 == Cond && Op1 == Val) || (Op0 == Val && Op1 == Cond)) {
+      LLVMContext &Ctx = Inst->getContext();
----------------
trentxintong wrote:
> efriedma wrote:
> > Missing check that Val is a ConstantInt.
> Val is going to be a ConstantInt, as its used by ICmpInst, I will add an assert though =).
It will  be a Constant of integer type... but that's not the same thing as a ConstantInt.  (For example `ptrtoint i32* @g to i64`. is a Constant of integer type.)


https://reviews.llvm.org/D28968