[PATCH] D28494: Make `@llvm.objectsize` more conservative with null pointers.

[Eric Christopher via Phabricator via llvm-commits]

echristo added a comment.

One inline request, otherwise I think this is ok. Not sure if we want to use an i2/i8 rather than a pair of i1, but either way.

-eric



================
Comment at: include/llvm/Analysis/MemoryBuiltins.h:146
+                   ObjSizeMode Mode = ObjSizeMode::Exact,
+                   bool NullIsUnknownSize = false);
 
----------------
As an enhancement I'd love to see this encapsulated into a preferences struct or something rather than two bools and an enum.


https://reviews.llvm.org/D28494