[PATCH] D29872: Do not legalize large add with addc/adde, introduce addcarry and do it with uaddo/addcarry

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

If possible it'd be great to split this down into smaller patches, which might be quicker to review overall.



================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:1902
+  return SDValue();
+}
+
----------------
Split this into a separate small patch + tests?


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:2517
+    }
+    LLVM_FALLTHROUGH;
   case ISD::ADD:
----------------
Could the ISD::UADDO case be split into a separate small patch + tests?


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:33951
+  return SDValue();
+}
+
----------------
Again, can this be extracted into its own patch + tests?


https://reviews.llvm.org/D29872