[PATCH] D29833: Improve the API of DILocation::getMergedLocation()

[Taewook Oh via Phabricator via llvm-commits]

twoh added a comment.

Personally I prefer the existing API, because it doesn't allow the transient state before merging. For example, in lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp in this patch, DebugLoc of NewSI is not actually valid after line 1430. Existing API doesn't have this problem.

I don't have strong opinion about scope, because anyway we won't be able to have precise scope. Taking DISubprogram of the destination instruction might be a conservative option.


Repository:
  rL LLVM

https://reviews.llvm.org/D29833