[PATCH] D28249: Improve scheduling with branch coalescing

[Lei Huang via Phabricator via llvm-commits]

lei marked 3 inline comments as done.
lei added inline comments.


================
Comment at: lib/CodeGen/BranchCoalescing.cpp:642
+
+  // Clean-up the control flow
+  // Remove SourceRegion.FallThroughBlock before transferring successors of
----------------
echristo wrote:
> Nit: All comments should be complete sentences. (A few other occurrences)
k.


================
Comment at: lib/CodeGen/BranchCoalescing.cpp:753
+  if (didSomething)
+    MF.verify(nullptr, "Error in code produced by branch coalescing");
+#endif // NDEBUG
----------------
kbarton wrote:
> Did we conclude whether this is different from the checks done by the verifyAfter parameter in addPass?
Yes. This is different from the checks done by the verifyAfter parameter in addPass.  The verifyAfter parameter for this pass is set to true by default.


https://reviews.llvm.org/D28249