[polly] r295713 - [DeLICM] Map values hoisted by LICM back to the array.

Michael Kruse via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 21 10:27:14 PST 2017


Done in r295741.

Michael

2017-02-21 16:41 GMT+01:00 Tobias Grosser <tobias.grosser at inf.ethz.ch>:
> On Tue, Feb 21, 2017, at 03:21 PM, Michael Kruse wrote:
>> 2017-02-21 13:50 GMT+01:00 Tobias Grosser <tobias.grosser at inf.ethz.ch>:
>> > Very cool. Thanks for putting this in!
>> >
>> > Btw, does it make sense to already enable this pass by default. As this
>> > is a conservative minimal implementation it seems perfect to already get
>> > test coverage from the start (also from our per-commit tests).
>>
>> I don't think it makes sense to enable it by default atm. That would
>> mean that everybody who tries Polly would get a compile time increase,
>> potentially more crashes/miscompiles without gaining anything in
>> practice. It's experimental.
>>
>> For getting coverage, we could set up a buildbot.
>
> Then maybe we should enable this flag on the
> -polly-position=before-vectorizer. Can you commit this flag change to
> zorg? Then it will be run from the next restart of the zorg buildbots.
>
> Best,
> Tobias


More information about the llvm-commits mailing list