[PATCH] D30206: [DWARF5] Emit new unit header

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 21 10:01:06 PST 2017


probinson added inline comments.


================
Comment at: include/llvm/DebugInfo/DWARF/DWARFUnit.h:127
   const DWARFAbbreviationDeclarationSet *Abbrevs;
+  uint8_t UnitType;
   uint8_t AddrSize;
----------------
I had noticed the packing here is not optimal, `Version` can move after `Abbrevs` to save a little space.  Not a big deal as there are usually relatively few units, but I thought I'd mention it.  Can be saved for a separate cleanup commit.


https://reviews.llvm.org/D30206





More information about the llvm-commits mailing list