[PATCH] D30043: [Polly][Cmake] Optionally use a system isl version.
Philip Pfaffe via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 21 06:33:56 PST 2017
philip.pfaffe marked an inline comment as done.
philip.pfaffe added inline comments.
================
Comment at: CMakeLists.txt:205-208
+ include_directories(
+ ${CMAKE_CURRENT_BINARY_DIR}/lib/External/isl/include
+ ${CMAKE_CURRENT_SOURCE_DIR}/lib/External/isl/include
+ )
----------------
Meinersbur wrote:
> I'd prefer to declare a variable `ISL_INCLUDE_DIRS` that contains the required directories and is set by the `POLLY_USE_EXTERNAL_ISL`-handling mechanism to the directories of choice. It avoids having extra cases for `POLLY_USE_EXTERNAL_ISL` whenever it is used.
>
> Would using `target_include_directories(PollyISL INTERFACE ...)` make this unnecessary?
I'm using ISL_INCLUDE_DIRS now.
`target_include_directories(PollyISL INTERFACE ...)` doesn't easily work here, because you can't have source-tree or build-tree paths on a targets INTERFACE when it's being installed.
https://reviews.llvm.org/D30043
More information about the llvm-commits
mailing list