[PATCH] D30043: [Polly][Cmake] Optionally use a system isl version.

[Philip Pfaffe via Phabricator via llvm-commits]

philip.pfaffe updated this revision to Diff 89194.
philip.pfaffe added a comment.

Addressed the comments. I also took the liberty to advance the minimum required cmake version for building out-of-tree. This patch doesn't work with cmake 2.8, because IMPORTED targets aren't supported.

Nevertheless I stumbled onto a minor issue with this approach: if linked into the LLVM tools, the rpaths are lost. CMake builds everything with full rpath by default, but LLVM overwrites this with $ORIGIN/../lib. If Polly is linked statically into a tool, e.g. opt, the isl rpath is gone. Without putting libisl into the LD_LIBRARY_PATH, opt won't find it, or might even pick up the wrong one.


https://reviews.llvm.org/D30043

Files:
  CMakeLists.txt
  lib/CMakeLists.txt
  lib/External/CMakeLists.txt
  test/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30043.89194.patch
Type: text/x-patch
Size: 17837 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170221/c62e89a1/attachment.bin>