[PATCH] D30124: [ARM] Fix insert point for store rescheduling.

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 21 05:02:36 PST 2017


rengolin added a comment.

Hi Eli,

Looks trivial, but would be better to have a target feature for this.

Also, would be better with an additional test where that threshold is crossed and we don't re-schedule the stores.

cheers,
--renato



================
Comment at: lib/Target/ARM/ARMLoadStoreOptimizer.cpp:2181
+      // Don't try to reschedule too many instructions.
+      if (++NumMove == 8) // FIXME: Tune this limit.
+        break;
----------------
I assume this would depend on sub-architecture, so better to have a target feature, even if it's the same value for all by default, this would allow much easier fiddling and changes in the future.


Repository:
  rL LLVM

https://reviews.llvm.org/D30124





More information about the llvm-commits mailing list