[PATCH] D29813: [DAGCombiner] Fix DebugLoc propagation when folding !(x cc y) -> (x !cc y)
Michael Kuperstein via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 20 20:21:18 PST 2017
mkuper added inline comments.
================
Comment at: test/CodeGen/X86/avx512-fsel.ll:15
; CHECK-NEXT: vucomiss %xmm1, %xmm0
-; CHECK-NEXT: setnp %cl
-; CHECK-NEXT: sete %dl
----------------
A drive-by comment: please don't manually change auto-generate tests - rather, rerun the script. You shouldn't need CHECK-DAG here anyway, since the scheduling is supposed to be deterministic.
(Also, I'm a bit confused. I can understand SDLoc changes affecting scheduling if we do source-order scheduling, but why would this make a difference for IR input that doesn't have any line info to begin with?)
https://reviews.llvm.org/D29813
More information about the llvm-commits
mailing list