[PATCH] D30178: Do not leak OpenedHandles

Frederich Munch via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 20 14:29:17 PST 2017


marsupial added a comment.

Believe it is fixed in my patch: allocating into a //std::unique_ptr// which should auto-destruct the contents on exit.
The ManagedStatic docs seems to talk about startup time, but I find it hard to believe that allocating space for a single pointer would be slower than the three it allocates plus other internals.

I'd prefer to use it in the patch I have as that addresses a more severe problem and this causes conflict resolution on my end.


Repository:
  rL LLVM

https://reviews.llvm.org/D30178





More information about the llvm-commits mailing list