[PATCH] D29989: [BasicAA] Take attributes into account when requesting modref info for a call site

[Daniel Berlin via Phabricator via llvm-commits]

dberlin added a comment.

I see what is happening.
Memdep gets a modref answer from AA, so it uses callCapturesBefore and then uses that instead.

I'm fine with having AA do this in modref, or using callCapturesBefore in MemorySSA.

Given that the related code says:
"/// FIXME: this is really just shoring-up a deficiency in alias analysis.
/// BasicAA isn't willing to spend linear time determining whether an alloca
/// was captured before or after this particular call, while we are. However,
/// with a smarter AA in place, this test is just wasting compile time."

we may just want to go ahead with basicaa ;)


https://reviews.llvm.org/D29989