[PATCH] D30154: MemorySSA: Add support for renaming uses in the updater.

Piotr Padlewski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 20 06:12:41 PST 2017


Prazek added inline comments.


================
Comment at: include/llvm/Transforms/Utils/MemorySSAUpdater.h:66
   MemorySSAUpdater(MemorySSA *MSSA) : MSSA(MSSA) {}
-  void insertDef(MemoryDef *Def);
+  // Insert a definition into the MemorySSA IR.  RenameUses will rename any use
+  // below the new def block (and any inserted phis).  RenameUses should be set
----------------
george.burgess.iv wrote:
> dberlin wrote:
> > george.burgess.iv wrote:
> > > should this be ///?
> > My understanding is that this isn't required anymore, but maybe i'm wrong?
> no clue. I'm happy to assume you're right; we can fix it later if doxygen doesn't like it. ¯\_(ツ)_/¯
I am not sure if doxygen will work, but I am used to doxygen comments for definitions because my ide color them differently :p


https://reviews.llvm.org/D30154





More information about the llvm-commits mailing list