[PATCH] D30160: AArch64AsmParser: tablegen the isBranchTarget helper functions

Oliver Stannard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 20 01:49:16 PST 2017


olista01 added inline comments.


================
Comment at: lib/Target/AArch64/AArch64InstrFormats.td:279
+
+def BranchTarget14Operand : BranchTarget<14, 0x2000, 0x1fff>;
+def BranchTarget26Operand : BranchTarget<26, 0x2000000, 0x1ffffff>;
----------------
Instead of listing the minimum and maximum values, could these just be calculated from the bit-width in isBranchTarget?


https://reviews.llvm.org/D30160





More information about the llvm-commits mailing list