[PATCH] D30154: MemorySSA: Add support for renaming uses in the updater.

[George Burgess IV via Phabricator via llvm-commits]

george.burgess.iv accepted this revision.
george.burgess.iv added a comment.

LGTM. Thanks again!



================
Comment at: include/llvm/Transforms/Utils/MemorySSAUpdater.h:66
   MemorySSAUpdater(MemorySSA *MSSA) : MSSA(MSSA) {}
-  void insertDef(MemoryDef *Def);
+  // Insert a definition into the MemorySSA IR.  RenameUses will rename any use
+  // below the new def block (and any inserted phis).  RenameUses should be set
----------------
dberlin wrote:
> george.burgess.iv wrote:
> > should this be ///?
> My understanding is that this isn't required anymore, but maybe i'm wrong?
no clue. I'm happy to assume you're right; we can fix it later if doxygen doesn't like it. ¯\_(ツ)_/¯


https://reviews.llvm.org/D30154