[PATCH] D30154: MemorySSA: Add support for renaming uses in the updater.

[Daniel Berlin via Phabricator via llvm-commits]

dberlin marked 11 inline comments as done.
dberlin added inline comments.


================
Comment at: include/llvm/Transforms/Utils/MemorySSA.h:692
+                  bool SkipVisited = false, bool RenameAllUses = false) {
+    renamePass(DT->getNode(BB), IncomingVal, Visited, true, true);
+  }
----------------
Prazek wrote:
> why 2 last params are not used?
There is only one caller that should be using it.
I removed the params here.


================
Comment at: include/llvm/Transforms/Utils/MemorySSAUpdater.h:66
   MemorySSAUpdater(MemorySSA *MSSA) : MSSA(MSSA) {}
-  void insertDef(MemoryDef *Def);
+  // Insert a definition into the MemorySSA IR.  RenameUses will rename any use
+  // below the new def block (and any inserted phis).  RenameUses should be set
----------------
george.burgess.iv wrote:
> should this be ///?
My understanding is that this isn't required anymore, but maybe i'm wrong?


https://reviews.llvm.org/D30154