[PATCH] D29107: Fix a bug when unswitching on partial LIV for SwitchInst

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

LGTM, but let's not fold in the changes to `RewriteLoopBodyWithConditionConstant` into this patch.



================
Comment at: lib/Transforms/Scalar/LoopUnswitch.cpp:684
+            continue;
+          // We are unswitching 0 out !.
+          UnswitchVal = AllZero;
----------------
Not sure what you meany by ` !.`.  If it is supposed to be sentence terminator then I'd just go with a period.  Same below.


================
Comment at: lib/Transforms/Scalar/LoopUnswitch.cpp:1338
     BasicBlock *SISucc = DeadCase.getCaseSuccessor();
     BasicBlock *Latch = L->getLoopLatch();
 
----------------
This bit is new right?  Let's do this change in a different commit and go with the bailout on a default switch case in `FindLIVLoopCondition` in the first step (but please add a FIXME to `FindLIVLoopCondition`).


https://reviews.llvm.org/D29107