[PATCH] D29107: Fix a bug when unswitching on partial LIV for SwitchInst

Xin Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Feb 18 17:10:57 PST 2017


trentxintong added inline comments.


================
Comment at: lib/Transforms/Scalar/LoopUnswitch.cpp:453
+        // operand(1).
+        OCS = CChain;
+        if (Value *RHS =
----------------
sanjoy wrote:
> This style is a bit awkward, IMO.  (In a later change, no need to pre-commit review) do you mind changing `FindLIVLoopCondition` to return `std::pair<Value *, OperatorChain>` as well?
Yes, I will do this in a subsequent commit.


https://reviews.llvm.org/D29107





More information about the llvm-commits mailing list