[PATCH] D30125: AMDGPU: Merge initial gfx9 support

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/AMDGPU.td:555
 
+// TODO: Either the name to be changed or we simply use IsCI!
 def isCIVI : Predicate <
----------------
kzhuravl wrote:
> Do you think we could switch generation from using islands to using GFX numbers for GCN in the long run? I am not sure for pre-GCN. This can be done in a separate patch and is not an immediate need.
> 
> SOUTHERN_ISLANDS = GFX6?
> SEA_ISLANDS = GFX7
> VOLCANIC_ISLANDS = GFX8
> 
> Then we could have isGFX7AndUp, isGFX8AndUp, etc.
> 
> Using islands is sometimes confusing (at least to me), and I have to open docs to match those to GFX numbers, or to find out if SEA_ISLANDS comes before or after CI :). GFX numbers are also matching nicely with ISA versions, and it is obvious that GFX7 comes after GFX6.
> 
> Also, ROCm docs (at least) use GFX numbers in readmes/manuals:
> https://radeonopencompute.github.io/install.html
Probably. I have the opposite problem and need to look up the numbers


https://reviews.llvm.org/D30125