[PATCH] D29862: LSR: an alternative way to resolve complex solution

[Quentin Colombet via llvm-commits]

> On Feb 17, 2017, at 4:26 PM, Evgeny Stupachenko via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> evstupac added a comment.
> 
>> 1. Should we set the option to true by default? I believe it would be best to keep it to false and send an email to llvm-dev to ask for benchmarking.
>> 2. The floating point thingy that I mentioned.
>> 
>> I am fine with moving forward with the current patch as long as you commit to look at #2.
> 
> Thanks, Quentin.
> I'm OOO next week. Committing the patch as is is the best option for me to get some feedback during my OOO.
> I'll commit it with the option set to "false" by default.
> It was set true in the review for 2 reasons: testing (if someone download patch as is) and to show influence on LIT tests.
> And I will not make the option true until a decision on #2. I'll look into it once I'm back.

Thanks for the heads-up.
You can set the default to true then and we’ll switch it back to false when you’re back. Make sure to ask for benchmarking in the meantime, as I believe bots are not necessarily reliable on that part.

> 
> Thanks,
> Evgeny
> 
> 
> Repository:
>  rL LLVM
> 
> https://reviews.llvm.org/D29862
> 
> 
>