[PATCH] D30115: [RFC] Add MachineInstr::MIFlag parameter to storeRegToStackSlot

[Simon Dardis via Phabricator via llvm-commits]

sdardis added a comment.

This looks ok to me, you should probably wait for others to comment. One major point I can see is that the base TTI object should have the default argument of MachineInstr::NoFlags for Flags. This should be documented in the comments as the expected behaviour. The target derived TII objects will also need this. It should reduce the number of cases of

  .setMIFlags(NoFlags);

appearing thought the codebase.


https://reviews.llvm.org/D30115